-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix toOrderedMap, toOrderedSet Flow annotations #850
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Actually this will introduce some problems. |
I also hit on this problem @marudor on the project https://github.com/facebook/draft-js with immutable '3.7.4' the flow build works just fine. But since the dependency on the package.json is set as '^0.7.4' the version that gets installed via npm install is ''3.8.1" which is incompatible and fails |
So #878 refactored the flow types and also added tests for them. Would you mind updating this PR to merge those changes in, and also add a test that catches this? Thanks! |
I fixed the merge conflicts in this PR / added tests / updated annotations for OrderedSet and OrderedMap in this PR: #1027 |
Hi there. I am starting handling backlog. I know it is been a while since you've submitted PR, sorry for such delay. The are some conflicts. Could you, please, rebase? 😅 |
@kozlitinaelja #1027 is merged into master, which is a superset of this PR. I think this PR can be closed. |
No description provided.