-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated flow types #881
Updated flow types #881
Conversation
`toOrderedSet` and `toOrderedMap` [were updated in the typescript definitions](#761), but not the flow ones.
@leebyron The changes in the above referenced PR caused the flow checks for draft-js to break. The changes here fix some of these. But there are more issues cropping up which have to do with incompatible types. Locally I tried copying over all the methods (minus the update methods) from the If so, I can update this PR to include those changes as well! |
I'm going to accept the PR to switch Draft to |
@johanneslumpe This repo is not actively maintained as far as I can see. I created a PR in flow-typed to add flow definitions for immutable there. My fork is here. Feel free to submit a PR with your changes there. |
So #878 refactored the flow types and also added tests for them. Would you mind updating this PR to merge those changes in, and also add a test that catches this? Thanks! |
OK, I am going to close this one in favor of 1027. |
toOrderedSet
andtoOrderedMap
were updated in the typescript definitions, but not the flow ones.