[WT-1798] Skip fetching fees estimates on top-up view #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepti-imx
commented
Oct 17, 2023
Comment on lines
+19
to
+24
| const tokenSymbol = token.symbol.toLocaleLowerCase() === 'timx' | ||
| ? IMX_TOKEN_SYMBOL | ||
| : token.symbol; | ||
| const gasFeeTokenConversion = conversions.get( | ||
| tokenSymbol.toLocaleLowerCase(), | ||
| ); |
There was a problem hiding this comment.
Added this check because swap fees is always -.-- in dev/sandbox env due to symbol being tIMX instead of IMX
There was a problem hiding this comment.
should we instead go token.address === IMX_ADDRESS_ZKEVM instead of token.symbol.toLocaleLowerCase() === 'timx' since symbol isnt unique identifier and the address should still be the 0x..1010 one
deepti-imx
commented
Oct 17, 2023
| @@ -33,7 +32,7 @@ export function TopUpMenuItem({ | |||
| </MenuItem.Label> | |||
| <MenuItem.IntentIcon /> | |||
| <MenuItem.Caption testId={`menu-item-caption-${testId}`}> | |||
| {isDisabled ? disabledCaption : caption} | |||
| {caption} | |||
There was a problem hiding this comment.
Removed the prop disabledCaption.
This is now handled in Top-up view to decide what text to show as caption
deepti-imx
commented
Oct 17, 2023
| @@ -4,19 +4,25 @@ import { | |||
| import { mount } from 'cypress/react18'; | |||
| import { BiomeCombinedProviders } from '@biom3/react'; | |||
| import { IMTBLWidgetEvents } from '@imtbl/checkout-widgets'; | |||
| import { Checkout, GasEstimateType, WalletProviderName } from '@imtbl/checkout-sdk'; | |||
| import { | |||
There was a problem hiding this comment.
Mostly linting on this file.
Added a new test case on line:412
deepti-imx
commented
Oct 17, 2023
| icon={element.icon as 'Wallet' | 'Coins' | 'Minting'} | ||
| heading={element.textConfig.heading} | ||
| caption={element.textConfig.caption} | ||
| caption={!element.isAvailable ? element.textConfig.disabledCaption : element.textConfig.caption} |
There was a problem hiding this comment.
Deciding what caption to show and removed prop disabledCaption
sharonsheah
approved these changes
Oct 17, 2023
imx-mikhala
reviewed
Oct 17, 2023
packages/checkout/widgets-lib/src/views/top-up/TopUpView.cy.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a feature is not enabled or is not available (geo-blocked), then skip the fees estimate fetching for that feature.
Screen.Recording.2023-10-17.at.14.01.42.mov
Made an improvement where the fees are displayed as and when they are fetched:
Screen.Recording.2023-10-17.at.15.13.35.mov
Why the changes
Things worth calling out
Before submitting the PR, please consider the following:
feat:,fix:,chore:,docs:, orrefactor:.