TD973 Update bulk fulfill interface to clearly communicate insufficient balance scenarios #1002
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously we would throw an error from the seaport.js SDK when balance from the fulfiller is not enough, this behaviour is not clear through the type interface, we now have an updated response schema design to better communicate this.
Why the changes
Things worth calling out
Before submitting the PR, please consider the following:
feat:
,fix:
,chore:
,docs:
, orrefactor:
.