Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NO-CHANGELOG] Adds Smart Checkout to state and flow of Sale Widget #1005
[NO-CHANGELOG] Adds Smart Checkout to state and flow of Sale Widget #1005
Changes from all commits
bfcd00e
69ecde3
cc07fe4
1a2a3a9
206a952
0462145
c51cb2e
f344b98
dba1d58
ff42b1c
2481aa6
937d923
64a703e
aba609b
aa6a25a
327007a
d06e18c
2bdc689
9b4299d
5ad0404
21de68c
00fac78
6bac19b
855e4a1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved all the SC logic stuff here, including calling
sign
before moving toPayWithCoins
.If there are funding routes, they get set here
setFundingRoutes()
. ThenFundWithSmartCheckout
only cares about two things globally:querySmartCheckout
onINIT
FundingRoutes
are set, showing these to user and letting them complete each step