[NO CHANGELOG] Orchestrates Swap/Bridge widgets for Smart Checkout routes #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ODS once on app load.
…immutable-sdk into GPR-238/widget-integration
jwhardwick
commented
Oct 20, 2023
packages/checkout/widgets-lib/src/widgets/sale/hooks/useSignOrder.ts
Outdated
Show resolved
Hide resolved
…-238/widget-integration
jwhardwick
changed the title
jhesgodi
reviewed
Oct 24, 2023
...checkout/widgets-lib/src/widgets/sale/components/FundingRouteExecute/FundingRouteExecute.tsx
Show resolved
Hide resolved
imx-mikhala
reviewed
Oct 24, 2023
packages/checkout/widgets-lib/src/widgets/sale/views/FundWithSmartCheckout.tsx
Outdated
Show resolved
Hide resolved
imx-mikhala
reviewed
Oct 24, 2023
imx-mikhala
reviewed
Oct 24, 2023
| @@ -27,20 +27,20 @@ export function FundWithSmartCheckout({ subView }: FundWithSmartCheckoutProps) { | |||
|
|
|||
| const { querySmartCheckout, fundingRoutes } = useSaleContext(); | |||
|
|
|||
| let smartCheckoutLoading = false; | |||
| const smartCheckoutLoading = useRef(false); | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
This one is because of useEffect double rendering, calling SmartCheckout twice in rapid succession causes them both to fail so had to prevent that in dev, not needed in prod though. Is it okay to keep in for now?
imx-mikhala
reviewed
Oct 24, 2023
packages/checkout/widgets-lib/src/widgets/sale/hooks/useSignOrder.ts
Outdated
Show resolved
Hide resolved
...checkout/widgets-lib/src/widgets/sale/components/FundingRouteExecute/FundingRouteExecute.tsx
Outdated
Show resolved
Hide resolved
imx-mikhala
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Smart.Checkout.swap.+.execute.flow.mov