Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NO CHANGELOG] Sales Widget - Smart Checkout no routes found flow #1053

Merged
merged 6 commits into from
Oct 25, 2023
Merged

[NO CHANGELOG] Sales Widget - Smart Checkout no routes found flow #1053

merged 6 commits into from
Oct 25, 2023

Conversation

jwhardwick
Copy link
Contributor

@jwhardwick jwhardwick commented Oct 24, 2023 •
edited
Loading

Summary

  • flips order of Coins/Card
  • after smart checkout returns with no funding routes:
    • removes error flow
    • takes user back to payment methods with banner + coins disabled
    • banner appears once only, disabled state persists.

image

@jwhardwick jwhardwick marked this pull request as ready for review October 24, 2023 05:03
@jwhardwick jwhardwick requested a review from a team as a code owner October 24, 2023 05:03
@jwhardwick jwhardwick changed the title Gpr 237/insufficient coins flow [NO CHANGELOG] Sales Widget - Smart Checkout no routes found flow Oct 24, 2023
sharonsheah
sharonsheah approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@sharonsheah sharonsheah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

@jwhardwick jwhardwick enabled auto-merge (squash) October 24, 2023 22:37
@jwhardwick jwhardwick merged commit c7add96 into main Oct 25, 2023
6 checks passed
@jwhardwick jwhardwick deleted the gpr-237/insufficient-coins-flow branch October 25, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhesgodi jhesgodi jhesgodi left review comments

@sharonsheah sharonsheah sharonsheah approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jwhardwick @jhesgodi @sharonsheah