[ID-1124][Passport]Add signIn function, changed connectEvm function to call slient login first #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmen0208
force-pushed
the
feature/ID-1124-add-signin-method-to-passport
branch
from
e03fe0e
to
59ca524
Compare
carmen0208
force-pushed
the
feature/ID-1124-add-signin-method-to-passport
branch
from
59ca524
to
b13466d
Compare
carmen0208
changed the title
carmen0208
force-pushed
the
feature/ID-1124-add-signin-method-to-passport
branch
from
a9b5183
to
3e164f8
Compare
yundifu
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Screen.Recording.2023-10-25.at.09.43.18.mov
Added
Changed
Changed the
connectImxfunction to call silent login before loginDepreicated
connectImxSilentfunctionThings worth calling out
Before submitting the PR, please consider the following:
feat:,fix:,chore:,docs:, orrefactor:.