Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NO CHANGELOG] Better error handling for useSignOrder #1067

Merged
merged 1 commit into from
Oct 25, 2023
Merged

[NO CHANGELOG] Better error handling for useSignOrder #1067

merged 1 commit into from
Oct 25, 2023

Conversation

jwhardwick
Copy link
Contributor

Summary

  • show an error instead of failing silently when missing deps
  • also adds provider to deps

@jwhardwick jwhardwick marked this pull request as ready for review October 25, 2023 05:52
@jwhardwick jwhardwick requested a review from a team as a code owner October 25, 2023 05:52
@jwhardwick jwhardwick merged commit 2abb058 into main Oct 25, 2023
6 checks passed
@jwhardwick jwhardwick deleted the fix-missing-provider-sale-widget branch October 25, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhesgodi jhesgodi jhesgodi approved these changes

@sharonsheah sharonsheah sharonsheah approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jwhardwick @jhesgodi @sharonsheah