fix: ID-1174 Passport - delay preload until window ready #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haydenfowler
changed the title
carmen0208
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves an issue where calling the Passport constructor before React had finished initialising (e.g. calling the constructor outside of a component) would result in subsequent interactions with the Magic SDK to fail. This would happen because the Magic iFrame would be appended to the DOM, but cleared out by shortly after when React initialises.
The fix is to delay the call to the
preloadfunction until the window / document is ready.Fixed
Before submitting the PR, please consider the following:
feat:,fix:,chore:,docs:, orrefactor:.