[ID-1178] keep login when silent login failed #1117
Conversation
| // eslint-disable-next-line no-console | ||
| console.warn('loginSilent failed with error:', error); |
There was a problem hiding this comment.
If we're expecting loginSilent to fail under certain circumstances, do we need this console.warn?
There was a problem hiding this comment.
Sorry, I wasn't aware of the situation that we expect loginSilent to fail. Can you make an example?
There was a problem hiding this comment.
Isn't the purpose of this PR to handle situations in which loginSilent throws an exception? I'm guessing if your token has expired then it will throw an exception?
There was a problem hiding this comment.
Yes, if the fresh token is used and expired, we can escape it and throw "Unknown or invalid refresh token." error. But the problem is it doesn't always mean the token is expired. with expectation.
Because the token will expired if
- Exceed very long period of time(around 1 year)
- Or it is used before
But ideally, it should not used before because if it is used, we expect the other tokens have been updated.
So that's why I feel it is still better to shown then warning as to build the awareness
carmen0208
deleted the
fix/ID-1178-keep-login-when-silent-login-failed
branch
Summary
Customer Impact
Added
Changed
Deprecated
Removed
Fixed
Security
Things worth calling out
Before submitting the PR, please consider the following:
feat:,fix:,chore:,docs:, orrefactor:.