fix: tokenId is uint256 so must be a BigNumber #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithbro-imx
changed the title
ZacharyCouchman
force-pushed
the
bug/tokenId-bignumber
branch
from
2c7ac99
to
5e3ca61
Compare
ZacharyCouchman
previously approved these changes
Apr 10, 2024
ZacharyCouchman
approved these changes
Apr 10, 2024
ckailash
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
tokenId is uint256 so must be a BigNumber
Test in checkout sdk-sample-app
Customer Impact
When listing NFTs with a number that is too big to fit in a JS number, it will succeed.
Added
Changed
Deprecated
Removed
Fixed
Security
Things worth calling out
Before submitting the PR, please consider the following:
feat:,fix:,chore:,docs:, orrefactor:.