Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [DX-2697] Use correct versions #1637

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Conversation

carleeto
Copy link
Contributor

@carleeto carleeto commented Apr 2, 2024

Hi👋, please prefix this PR's title with:

  • breaking-change: if you have introduced modification that necessitates immediate adjustments by this SDK's users to their applications, clients, or integrations to avert disruptions to existing features or functionalities.
  • feat:, fix:, refactor:, docs:, or chore:.

Summary

Fix args used when calling version-up.sh in the publish workflow
Also add debugging statements for the future

Anything else worth calling out?

This might be easier to review commit by commit.
No code / functionality changes to the SDK

when release_type is release AND
upgrade_type is none AND
the latest tag is an alpha

call version-up with --release --apply
instead of --release -- --apply
@carleeto carleeto requested review from CodeSchwert and a team April 2, 2024 05:02
@carleeto carleeto marked this pull request as ready for review April 2, 2024 05:04
@carleeto carleeto enabled auto-merge (squash) April 2, 2024 05:04
@carleeto carleeto merged commit 7eb0a8d into main Apr 3, 2024
11 checks passed
@carleeto carleeto deleted the DX-2697/correct-versions branch April 3, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants