Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [GPR-536][Sale Widget] Get multiple currencies #1653

Merged
merged 26 commits into from
Apr 12, 2024
Merged

feat: [GPR-536][Sale Widget] Get multiple currencies #1653

merged 26 commits into from
Apr 12, 2024

Conversation

mimi-imtbl
Copy link
Contributor

@mimi-imtbl mimi-imtbl commented Apr 8, 2024 •
edited
Loading

Summary

Add functionality to the sale widget to get multiple currencies.

Added

  • Add logic to useClientConfig hook to manage and aggregate currencies
  • Getting lists of currencies from sale BE & checkout config
  • Mark settlement vs swappable currencies
  • Add function to remove duplicated currencies in the aggregated currency list & sort it based on priority: base currency -> settlement currencies -> swappable currencies
  • Set base currency as selectedCurrency
  • Add error handling
  • Add tests to utils functions

@mimi-imtbl mimi-imtbl changed the title Feat/gpr 536 sale widget update client config get multiple currencies WIP - Feat/gpr 536 sale widget update client config get multiple currencies Apr 8, 2024
@mimi-imtbl mimi-imtbl changed the title WIP - Feat/gpr 536 sale widget update client config get multiple currencies feat/gpr 536 sale widget get multiple currencies Apr 9, 2024
@mimi-imtbl mimi-imtbl marked this pull request as ready for review April 9, 2024 05:14
@mimi-imtbl mimi-imtbl requested a review from a team as a code owner April 9, 2024 05:14
@mimi-imtbl mimi-imtbl requested a review from a team April 9, 2024 05:14
@mimi-imtbl mimi-imtbl requested a review from a team April 10, 2024 23:09
@jhesgodi jhesgodi changed the title feat/gpr 536 sale widget get multiple currencies feat: [GPR-536][Sale Widget] Get multiple currencies Apr 11, 2024
@mimi-imtbl mimi-imtbl requested a review from a team as a code owner April 11, 2024 05:24
jhesgodi
jhesgodi previously approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@jhesgodi jhesgodi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 LGTM, approved with minor comments @mimi-imtbl

dreamoftrees
dreamoftrees approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@dreamoftrees dreamoftrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @mimi-imtbl

@mimi-imtbl mimi-imtbl added this pull request to the merge queue Apr 12, 2024
Merged via the queue into main with commit 915b273 Apr 12, 2024
13 checks passed
@mimi-imtbl mimi-imtbl deleted the feat/gpr-536-sale-widget-update-client-config-get-multiple-currencies branch April 12, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamoftrees dreamoftrees dreamoftrees approved these changes

@jhesgodi jhesgodi jhesgodi approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mimi-imtbl @dreamoftrees @jhesgodi