ID-1598 Passport Fee Option optimisation #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Skip signature step - Use arbitrary nonce for estimating meta transaction
Jon-Alonso
changed the title
yundifu
approved these changes
May 14, 2024
andrearampin
approved these changes
May 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated the gas estimation strategy to no longer require a nonce and signature for performance reasons. This allows us to parallelize the nonce generation and transaction estimation and skip the signature step.
This change is backwards compatible.
Context: https://immutable.atlassian.net/wiki/spaces/PA/pages/2507669554/Passport+-+Gas+estimation+optimisation
OLD EXPERIENCE
Arbitrary transactions example:
old-generic.mov
Native IMX transfer example:
old-transfer.mov
NEW EXPERIENCE
Arbitrary transactions example:
opt-2-generic.mov
Native IMX transfer example:
opt-2-transfer.mov