feat: minting-backend, webhook utility #1732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
shineli1984
commented
May 10, 2024
| @@ -0,0 +1,3 @@ | |||
| # Webhook | |||
|
|
|||
| This package consists of utility to work with [Immutable webhooks](https://docs.immutable.com/docs/zkEVM/products/blockchain-data/webhooks) | |||
There was a problem hiding this comment.
TODO in separate PR: adding more readme.
alexi21
previously approved these changes
May 10, 2024
carleeto
previously approved these changes
May 10, 2024
brayansdt
previously approved these changes
May 10, 2024
packages/webhook/sdk/src/init.ts
Outdated
| }); | ||
|
|
||
| // check for topic arn prefix | ||
| if (!msg.TopicArn.startsWith(allowedTopicArnPrefix[env])) { |
There was a problem hiding this comment.
is there a way to check this first before confirming subscription? Otherwise the partner may confirm a subscription from a malicious actor
There was a problem hiding this comment.
aha... right right.
shineli1984
dismissed stale reviews from brayansdt, carleeto, and alexi21
via
af899f6
packages/minting-backend/sdk/src/minting/dbClient/postgres.ts
Dismissed
Show dismissed
Hide dismissed
packages/minting-backend/sdk/src/minting/dbClient/postgres.ts
Dismissed
Show dismissed
Hide dismissed
valzam
previously approved these changes
May 10, 2024
charlie-chau
approved these changes
May 12, 2024
ipekt
approved these changes
May 13, 2024
CodeSchwert
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi👋, please prefix this PR's title with:
feat:,fix:,refactor:,docs:, orchore:.Summary
For reviewers