refactor:[SMR-2725] util functions #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tokenBridge class
…into smr-2717-bridge-validation-separate
…com/immutable/ts-immutable-sdk into smr-2718-create-validateGetFee
…into smr-2718-create-validateGetFee
…into smr-2718-create-validateGetFee
Benjimmutable
changed the title
Benjimmutable
commented
May 7, 2024
Comment on lines
+65
to
+68
|
|
||
| export const exportedForTesting = { | ||
| getAddresses, | ||
| }; |
There was a problem hiding this comment.
Not sure what we think about the export and test pattern here but LMK opinions
…into smr-2719-tenderlysimulation-type
Benjimmutable
changed the base branch from
main
to
smr-2722-calculate-gas-fee-moved
Benjimmutable
changed the base branch from
smr-2722-calculate-gas-fee-moved
to
smr-2719-tenderlysimulation-type
ermyas
approved these changes
May 7, 2024
ermyas
previously approved these changes
May 7, 2024
Benjimmutable
dismissed
ermyas’s stale review
The merge-base changed after approval.
ermyas
approved these changes
May 8, 2024
wcgcyx
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move util functions for fetching particular bridge-related addresses into a separate file
Also remove some duplicate code by splitting it out into a new function.
Detail and impact of the change
Added
getAddressesfunction for reading from aRecordfrom network to address.Changed
getAddresses:lib/utils.ts