Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Regenerate interal OpenAPI clients #1750

Merged
merged 1 commit into from
May 9, 2024

Conversation

valzam
Copy link
Contributor

@valzam valzam commented May 8, 2024

Hi馃憢, please prefix this PR's title with:

  • breaking-change: if you have introduced modification that necessitates immediate adjustments by this SDK's users to their applications, clients, or integrations to avert disruptions to existing features or functionalities.
  • feat:, fix:, refactor:, docs:, or chore:.

Summary

Regenerate internal OpenAPI clients to be in sync with current production API

Detail and impact of the change

Added

  • Added from_updated_at filter to ListNFTsByAccountAddress
  • Added account_address filter to ListOwnersByContractAddress
  • Added amount field to Sale Activity return type for sales involving ERC1155 tokens
  • Added amount to CreateMintRequest and ListMintRequest to support minting on ERC1155 colllections

Changed

  • SeaportCreateListingMetadata only accepts a single sell item instead of an array

Deprecated

  • getLinkedAddresses in passport package is marked is now deprecated

@valzam valzam requested a review from a team as a code owner May 8, 2024 05:43
@valzam
Copy link
Contributor Author

valzam commented May 8, 2024

Checked with passport team and the changes to SeaportCreateListingMetadata are not problematic, the passport sdk actually already uses the new version. The team doesn't expect any users to use the ts sdk for this functionality.

@valzam valzam enabled auto-merge May 9, 2024 00:17
@valzam valzam added this pull request to the merge queue May 9, 2024
Merged via the queue into main with commit 9142ba1 May 9, 2024
11 checks passed
@valzam valzam deleted the GMS-1696-regenerate-sdk-to-include-new-amount-field branch May 9, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants