fix: Coin logos not loading in the Balance Widget #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @keithbro-imx I'm happy to aprove this if its a blocker for you.. I'm also working on a ticket at the moment to remove the use of CloudImage component across all the widgets for token images as they won't work outside of Immutable.com domains (ie on TokenTrove/Sphere) as the image resizer WAF is restricted.. so this implementation will change shortly. |
mimi-imtbl
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi馃憢, please prefix this PR's title with:
breaking-change:if you have introduced modification that necessitates immediate adjustments by this SDK's users to their applications, clients, or integrations to avert disruptions to existing features or functionalities.feat:,fix:,refactor:,docs:, orchore:.Summary
MenuItem.FramedImageusesCloudImageunder the hood, so you need to pass theimageResizeServiceUrlto it in order for the image to load in sandbox and prod.There are other instances of
MenuItem.FramedImagethat needs this fix, but this PR fixes the known occurrence of this in the Gems Game.Detail and impact of the change
Added
Changed
Deprecated
Removed
Fixed
Security
Anything else worth calling out?