Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [CM-632][Sale Widget] Add configuration flat to enable/disable transaction finality confirmation #1753

Merged
merged 3 commits into from
May 10, 2024

Conversation

mimi-imtbl
Copy link
Contributor

@mimi-imtbl mimi-imtbl commented May 9, 2024

Hi馃憢, please prefix this PR's title with:

  • breaking-change: if you have introduced modification that necessitates immediate adjustments by this SDK's users to their applications, clients, or integrations to avert disruptions to existing features or functionalities.
  • feat:, fix:, refactor:, docs:, or chore:.

Added

Added waitFulfillmentSettlements to sale widget config to enable/disable wait for transaction settlement. true by default.

@mimi-imtbl mimi-imtbl requested a review from a team as a code owner May 9, 2024 03:46
@mimi-imtbl mimi-imtbl changed the title [feat] cm 632 sale widget waitFulfillmentSettlements [feat] cm-632 sale widget waitFulfillmentSettlements May 9, 2024
jwhardwick
jwhardwick previously approved these changes May 9, 2024
Copy link
Contributor

@jhesgodi jhesgodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left comment re initial state

@jhesgodi jhesgodi changed the title [feat] cm-632 sale widget waitFulfillmentSettlements feat: [CM-632][Sale Widget] Add configuration flat to enable/disable transaction finality confirmation May 9, 2024
@mimi-imtbl mimi-imtbl added this pull request to the merge queue May 10, 2024
Merged via the queue into main with commit fe1269a May 10, 2024
11 checks passed
@mimi-imtbl mimi-imtbl deleted the feat/cm-632-sale-widget-waitFulfillmentSettlements branch May 10, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants