Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] [CM-636] Add L1 warning for passport users in Settings view #1755

Merged
merged 12 commits into from
May 14, 2024

Conversation

mimi-imtbl
Copy link
Contributor

@mimi-imtbl mimi-imtbl commented May 9, 2024

Hi👋, please prefix this PR's title with:

  • breaking-change: if you have introduced modification that necessitates immediate adjustments by this SDK's users to their applications, clients, or integrations to avert disruptions to existing features or functionalities.
  • feat:, fix:, refactor:, docs:, or chore:.

Summary

Add a warning drawer to Settings view to warn users about transferring assets to L1.

Detail and impact of the change

Added

  • abbreviate wallet address
  • add eye icon for passport
  • add the warning drawer for passport users, let them copy wallet address from the drawer
Screenshot 2024-05-10 at 1 15 39 PM Screenshot 2024-05-10 at 1 15 47 PM

@mimi-imtbl mimi-imtbl changed the title [WIP]Revamp balance widget settings view [feat] [CM-636] Add L1 warning for passport users in Settings view May 10, 2024
@mimi-imtbl mimi-imtbl marked this pull request as ready for review May 10, 2024 03:59
@mimi-imtbl mimi-imtbl requested a review from a team as a code owner May 10, 2024 03:59
@mimi-imtbl mimi-imtbl requested review from jhesgodi, jwhardwick and a team May 10, 2024 06:17
jhesgodi
jhesgodi previously approved these changes May 10, 2024
Copy link
Contributor

@jwhardwick jwhardwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work @mimi-imtbl 🚀

@mimi-imtbl mimi-imtbl enabled auto-merge May 14, 2024 00:43
@mimi-imtbl mimi-imtbl disabled auto-merge May 14, 2024 00:43
Copy link
Contributor

@dreamoftrees dreamoftrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff @mimi-imtbl


useEffect(() => {
if (!provider) return;
if (!provider || walletAddress !== '') return;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice check here 👍

@mimi-imtbl mimi-imtbl added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit d0d48ea May 14, 2024
11 checks passed
@mimi-imtbl mimi-imtbl deleted the feat/cm-636-sending-assets-l1-warning branch May 14, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants