Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less is more #1766

Merged
merged 4 commits into from
May 21, 2024
Merged

Less is more #1766

merged 4 commits into from
May 21, 2024

Conversation

shineli1984
Copy link
Collaborator

@shineli1984 shineli1984 commented May 11, 2024

This is a temporary stopgap solution to solve the manual and slow development feedback loop when iterating sample apps and sdk together.

Optimised development workflow

Running the following command at the root of repo will watch for any changes once built.

# yarn run dev

This short term fix will involve running rollup in watch mode as the dev command to quickly rebuild on save for changes, rather than manually building out everything.

Slack thread for additional context: https://imtbl.slack.com/archives/C07332F3X9Q/p1715902163844719

Future plans involve discussing the attempt to move away from the dist folder as the export for a package, and using the src folder directly instead, which would prevent the need for any rebuilds on save as the TypeScript server would be able to pick up the changes immediately.

If this won't be possible, the next step would be caching rebuilds as much as possible to minimize unnecessary builds, and speeding up the TS to JS compilation and TS declaration files creation as much as possible.

Notes

  • If you've never run yarn build or yarn dev before, yarn dev might fail as it’s running in parallel and could be missing package dependencies. It would be best to ensure yarn build has been run and built packages are available before running dev mode.
  • You need to make sure your sample app/package has a dev script to make it work

Example workflow with this rollup watch mode fix:

20240517101239842.mp4

@zaidarain1 zaidarain1 marked this pull request as ready for review May 17, 2024 01:36
@zaidarain1 zaidarain1 requested review from a team as code owners May 17, 2024 01:36
@zaidarain1 zaidarain1 marked this pull request as draft May 17, 2024 06:01
@zaidarain1 zaidarain1 marked this pull request as ready for review May 21, 2024 00:16
@zaidarain1 zaidarain1 added this pull request to the merge queue May 21, 2024
Merged via the queue into main with commit 73460f8 May 21, 2024
11 checks passed
@zaidarain1 zaidarain1 deleted the less_is_more branch May 21, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants