refactor:[SMR-2730] rewrite get tx data #1781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into smr-2730-rewrite-getTxData
Benjimmutable
commented
May 17, 2024
| currentBridgeMethods.native, | ||
| [amount], | ||
| ), BridgeErrorType.INTERNAL_ERROR); | ||
| functionName = currentBridgeMethods.native; |
There was a problem hiding this comment.
the new way of doing it feels a lot easier to read to me
wcgcyx
approved these changes
May 20, 2024
ermyas
reviewed
May 20, 2024
| @@ -384,39 +384,40 @@ export class TokenBridge { | |||
| const currentBridgeMethods = await this.getBridgeMethods(direction); | |||
| const bridgeContract = await this.getBridgeContract(direction); | |||
|
|
|||
| let functionName: string; | |||
| let parameters: any[]; | |||
| /** | |||
| * Handle bridge transaction for native token | |||
| */ | |||
| if (token.toUpperCase() === NATIVE) { | |||
| if (sender === recipient) { | |||
There was a problem hiding this comment.
should we handle scenario where a checksummed version of an address might evaluate different from a non-checksummed version?
There was a problem hiding this comment.
Yep. Ticket created
ermyas
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rewrite
getTxDatain bridge SDKDetail and impact of the change
If you do not think this is a better way to write this function, please voice this opinion. I personally believe it is easier to read.
Changed
getTxDataso you just set the function name and parameters then generate the calldata based on those, since you already have the correct bridge contract to do it on as well.