Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [Sale WIdget] Do not render more options section when all options are disabled #1813

Merged
merged 1 commit into from
May 22, 2024
Merged

fix: [Sale WIdget] Do not render more options section when all options are disabled #1813

merged 1 commit into from
May 22, 2024

Conversation

jhesgodi
Copy link
Contributor

@jhesgodi jhesgodi commented May 21, 2024 •
edited

Summary

Do not render more options section when all options are disabled

Screenshots

Given that debit and credit options were disabled:

Before
Screenshot 2024-05-22 at 9 05 40 AM

After
Screenshot 2024-05-22 at 9 04 51 AM

@jhesgodi jhesgodi requested a review from a team as a code owner May 21, 2024 23:05
@jhesgodi jhesgodi force-pushed the fix/coins-drawer-more-options branch from e395887 to fc715d8 Compare May 22, 2024 01:17
@jhesgodi jhesgodi enabled auto-merge May 22, 2024 01:57
dreamoftrees
dreamoftrees approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@dreamoftrees dreamoftrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice fix!

@jhesgodi jhesgodi added this pull request to the merge queue May 22, 2024
Merged via the queue into main with commit 6d25d98 May 22, 2024
11 checks passed
@jhesgodi jhesgodi deleted the fix/coins-drawer-more-options branch May 22, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luads luads luads approved these changes

@dreamoftrees dreamoftrees dreamoftrees approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jhesgodi @luads @dreamoftrees