feat: bulk listing creation from orderbook SDK #1885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankisawesome
previously approved these changes
Jun 12, 2024
| @@ -9,3 +10,26 @@ export function getOrderComponentsFromMessage(orderMessage: string): OrderCompon | |||
|
|
|||
| return orderComponents; | |||
| } | |||
|
|
|||
| export function getBulkOrderComponentsFromMessage(orderMessage: string): OrderComponents[] { | |||
There was a problem hiding this comment.
Seems like bespoke and error prone logic here? Just observation
There was a problem hiding this comment.
Yeh undeniably not ideal - but unfortunately there is no real way around it because of how we expose the signable message to callers, rather than using the inbuilt seaport-js methods
|
|
||
| const domainData = { | ||
| name: SEAPORT_CONTRACT_NAME, | ||
| version: SEAPORT_CONTRACT_VERSION_V1_5, |
There was a problem hiding this comment.
Is this something we want to put in to a config/env? Especially now that we use it in multiple places, could be easy to forget if we move to 1.6
There was a problem hiding this comment.
Those constant values are all imported from seaport/constants.ts. If we move versions updating there will modify all the places we create this message
| listingParams: orderParams, | ||
| }); | ||
|
|
||
| const signatures = await actionAll(actions, offerer); |
Sam-Jeston
force-pushed
the
TD-1498-bulk-listings
branch
from
626fab9
to
188ef04
Compare
lfportal
reviewed
Jun 18, 2024
lfportal
previously approved these changes
Jun 18, 2024
Sam-Jeston
force-pushed
the
TD-1498-bulk-listings
branch
from
5325c1b
to
6628288
Compare
shineli1984
approved these changes
Jun 18, 2024
CodeSchwert
approved these changes
Jun 18, 2024
lfportal
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement bulk listing creation from the orderbook SDK. When the bulk listing methods are called with single items, the existing prepareListing and createListing methods are delegated to instead, reducing the impact on enriched confirmations for the majority of users who will not be listing in bulk.
Detail and impact of the change
Added