[NO-CHANGELOG] feat: primary revenue widget hooks - part 2 #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhesgodi
changed the base branch from
main
to
GPR-91-primary-sale-playground-setup
added 2 commits
September 26, 2023 13:54
jhesgodi
changed the base branch from
GPR-91-primary-sale-playground-setup
to
gpr/primary-revenue-widget-setup
mimi-imtbl
approved these changes
Sep 26, 2023
packages/checkout/widgets-lib/src/widgets/primary-revenue/hooks/useSignOrder.ts
Show resolved
Hide resolved
jhesgodi
requested review from
a team and
proletesseract
and removed request for
a team
jhesgodi
commented
Oct 2, 2023
| @@ -35,7 +36,15 @@ export function PrimaryRevenueWidget(props: PrimaryRevenueWidgetProps) { | |||
| config, amount, items, fromContractAddress, env, environmentId, | |||
| } = props; | |||
|
|
|||
| console.log('@@@ PrimaryRevenueWidget', config, amount, items, fromContractAddress, env, environmentId); | |||
| console.log( | |||
There was a problem hiding this comment.
keeping it to skip eslint check, gets remove in the next PRs.
There was a problem hiding this comment.
You can add an eslint ignore above the console log
jhesgodi
commented
Oct 2, 2023
packages/checkout/widgets-lib/src/widgets/primary-revenue/hooks/useSignOrder.ts
Show resolved
Hide resolved
|
@ZacharyCouchman / @proletesseract May please request your review here. Cheers |
| }; | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/naming-convention | ||
| const SharedContext = createContext<SharedContextValues>({ |
There was a problem hiding this comment.
Just a question on naming, any reason why you are not calling this PrimaryRevenueContext? Or something like that?
There was a problem hiding this comment.
No reason, we can name to PrimaryRevenueContext as per your suggestion.
ZacharyCouchman
approved these changes
Oct 3, 2023
deepti-imx
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a shared context provider for primary revenue views
Why the changes
Enables sharing the state the views and subviews required for smart checkouts and sign order