feat: [WT-1732] Smart Checkout swap route supports multiple swap paths #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imx-mikhala
reviewed
Sep 26, 2023
imx-mikhala
reviewed
Sep 26, 2023
packages/checkout/sdk/src/smartCheckout/routing/swap/swapRoute.ts
Outdated
Show resolved
Hide resolved
imx-mikhala
reviewed
Sep 26, 2023
packages/checkout/sdk/src/smartCheckout/routing/routingCalculator.ts
Outdated
Show resolved
Hide resolved
imx-mikhala
reviewed
Sep 26, 2023
packages/checkout/sdk/src/smartCheckout/routing/routingCalculator.ts
Outdated
Show resolved
Hide resolved
dreamoftrees
force-pushed
the
feature/WT-1732
branch
from
e313dea
to
ba97cd5
Compare
imx-mikhala
approved these changes
Sep 27, 2023
packages/checkout/sdk/src/smartCheckout/routing/routingCalculator.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Smart Checkout swap route should return all swappable funding routes available. The current implementation returns only the first available funding route.
WT-1732
Before submitting the PR, please consider the following: