[GMS-1086] refactor: Remove contract clients #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allan-almeida
commented
Sep 27, 2023
| @@ -10,8 +10,6 @@ | |||
| "@0xsequence/config": "^0.43.34", | |||
| "@ethersproject/abi": "^5.7.0", | |||
| "@ethersproject/abstract-signer": "^5.7.0", | |||
| "@ethersproject/bignumber": "^5.7.0", | |||
There was a problem hiding this comment.
These two were automatically removed when I ran yarn build
CodeSchwert
approved these changes
Sep 27, 2023
valzam
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove contract clients from the SDK
Background: https://immutable.atlassian.net/wiki/spaces/IGG/pages/2262959181/Moving+Contract+Clients+out+of+SDK
Why the changes
Contract client versions need to be decoupled from sdk versions, and instead be coupled to smart contract updates. This is to avoid versioning issues for customers who have deployed an older version of our preset contract but still want access to SDK updates that are not contract related.
Things worth calling out
Publish to NPMdry run succesful: https://github.com/immutable/ts-immutable-sdk/actions/runs/6331246693Contract clients have already been added to repo zkevm-contracts
Docs have already been updated to instruct using zkevm contracts instead of SDK contract clients
Before submitting the PR, please consider the following:
feat:,fix:,chore:,docs:, orrefactor:.