[ID-1099]getUser will get new token when existed token expired. #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmen0208
changed the title
haydenfowler
reviewed
Oct 2, 2023
haydenfowler
reviewed
Oct 2, 2023
haydenfowler
reviewed
Oct 3, 2023
| @@ -28,6 +28,7 @@ | |||
| "@swc/jest": "^0.2.24", | |||
There was a problem hiding this comment.
We'll also need to add this devDependency to packages/passport/package.json (seems as though jwt-decode was somehow missed 🤔)
There was a problem hiding this comment.
might be because it already included in yarn.lock: https://github.com/immutable/ts-immutable-sdk/blob/main/yarn.lock#L21022
I will add the package json anyway. would be in dependency thought as the code need to be run within the build sdk.
haydenfowler
reviewed
Oct 3, 2023
haydenfowler
reviewed
Oct 3, 2023
haydenfowler
reviewed
Oct 3, 2023
haydenfowler
reviewed
Oct 3, 2023
haydenfowler
approved these changes
Oct 3, 2023
carmen0208
deleted the
feature/ID-1099-get-user-not-return-expired-user
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Why the changes
Things worth calling out
Before submitting the PR, please consider the following:
feat:,fix:,chore:,docs:, orrefactor:.