fix: WT-1750 Patch DOM ID clashing #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrearampin
force-pushed
the
WT-1750
branch
from
e06fb9b
to
33838dc
Compare
andrearampin
commented
Sep 29, 2023
| @@ -7,7 +7,7 @@ import { CoinSelector } from '../../CoinSelector/CoinSelector'; | |||
| import { CoinSelectorOptionProps } from '../../CoinSelector/CoinSelectorOption'; | |||
|
|
|||
| interface SelectFormProps { | |||
| id: string; | |||
There was a problem hiding this comment.
this was used for testing -- move it to testId to prevent DOM id clashing
andrearampin
commented
Sep 29, 2023
| @@ -9,7 +9,7 @@ import { TextInputForm } from '../TextInputForm/TextInputForm'; | |||
| import { CoinSelectorOptionProps } from '../../CoinSelector/CoinSelectorOption'; | |||
|
|
|||
| interface SelectInputProps { | |||
| id: string; | |||
There was a problem hiding this comment.
this was used for testing -- move it to testId to prevent DOM id clashing
dreamoftrees
reviewed
Oct 3, 2023
There was a problem hiding this comment.
Nice clean up @andrearampin 👍 Just a minor question around the actual use of id across the Box elements.
packages/checkout/widgets-lib/src/widgets/connect/views/ConnectWallet.tsx
Outdated
Show resolved
Hide resolved
packages/checkout/widgets-lib/src/components/SimpleLayout/SimpleLayout.tsx
Outdated
Show resolved
Hide resolved
dreamoftrees
approved these changes
Oct 3, 2023
carmen0208
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
BIOME and Checkout used to have components with the same ID making it not possible for BIOME to correctly target the some DOM elements.
https://immutable.atlassian.net/browse/WT-1750
Screen.Recording.2023-10-03.at.3.22.04.pm.mov
Why the changes
Bug when multiple widgets are rendered on a web page
Things worth calling out
Before submitting the PR, please consider the following:
feat:,fix:,chore:,docs:, orrefactor:.