WT-1734 Add fees to swap and bridge routes #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imx-mikhala
commented
Oct 5, 2023
| @@ -450,34 +450,22 @@ export type NoRouteOptions = { | |||
| * Represents a funding route | |||
| * @property {number} priority - The priority of the route | |||
| * @property {FundingStep[]} steps - The steps associated with this funding route | |||
| * @property {TotalFees | undefined} totalFees - The total fees for this route | |||
There was a problem hiding this comment.
Think it makes more sense to just leave fees at the funding step level. Fees can in theory be various tokens and so they would need to be aggregated by token. Think it makes more sense to have only at the funding step level, especially because onramp cant even have one of these fee fields
andrearampin
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the fees to the swap and bridge funding steps
Removed the total fees at top level as fees can be in various tokens (even if all currently native) so different token fees cant really be aggregated into one value and doesn't make sense for the on-ramp route. Think it makes more sense to just have the fees associated with the funding step.