WT-1760 Return resolved dex quotes if any reject #945
Conversation
| @@ -25,6 +25,7 @@ export const quoteFetcher = async ( | |||
|
|
|||
| // Create a quote for each swappable token | |||
| for (const swappableToken of swappableTokens) { | |||
| if (swappableToken === requiredToken.address) continue; | |||
There was a problem hiding this comment.
@imx-mikhala shouldn't this at the start of the quoteFetcher function?
There was a problem hiding this comment.
nope, we are looping through an array of swappable tokens and checking that the swappable token for that loop is not the same as the required token we want to get token pair quotes for
| dexTransactionResponse.forEach((response, index) => { | ||
| if (response.status === 'rejected') return; // Ignore any requests to dex that failed to resolve |
There was a problem hiding this comment.
@imx-mikhala this is 👍 however shall we expose the reason for this promise to be rejected (e.g. missing liquidity pool)?
There was a problem hiding this comment.
how do you think is best to surface this? just by logging?
There was a problem hiding this comment.
I think we are fetching quotes as a best effort thing. No need to really tell the user if one quote failed to resolve. I'd think about what the output of this should be if all quote responses were erroring.
There was a problem hiding this comment.
I agree with @ZacharyCouchman I think if there is an error that could be mitigated by the user and we couldn't find any swap options then responding with that might give them a pathway forward.. not sure what those error types would be though. But otherwise might just be too much noise as it is best effort.
Summary
This PR ensures that if any of the dex quotes reject then the resolved ones will still return.
Also adds in a check to make sure we do not call the dex with a matching to/from token as this is not a valid dex call.