Gpr 213/funding route state pr branch #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwhardwick
force-pushed
the
gpr-213/funding-route-state-pr-branch
branch
from
00e189b
to
754eefa
Compare
jwhardwick
commented
Oct 5, 2023
| )} | ||
| { subView === FundWithSmartCheckoutSubViews.DONE && ( | ||
| <p> | ||
| FundWithSmartCheckout done! |
There was a problem hiding this comment.
Placeholder for later functionality.
jwhardwick
commented
Oct 5, 2023
| {' '} | ||
| { fundingRouteStep?.asset.token.symbol } | ||
|
|
||
| <Button sx={{ mt: 'auto' }} variant="primary" onClick={onFundingRouteExecuted}> |
There was a problem hiding this comment.
Placeholder for later functionality.
…able/ts-immutable-sdk into gpr-213/funding-route-state-pr-branch
imx-mikhala
approved these changes
Oct 6, 2023
jwhardwick
force-pushed
the
gpr-208/sc-events-layout-pr-branch
branch
2 times, most recently
from
dc0fd71
to
713a0e8
Compare
jhesgodi
approved these changes
Oct 10, 2023
…-213/funding-route-state-pr-branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
FundingRouteExecute, which orchestrates themWhy the changes
Things worth calling out
Before submitting the PR, please consider the following:
feat:,fix:,chore:,docs:, orrefactor:.