feat: wt 1781 create availability service #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharonsheah
commented
Oct 10, 2023
sharonsheah
commented
Oct 10, 2023
deepti-imx
previously approved these changes
Oct 10, 2023
imx-mikhala
reviewed
Oct 10, 2023
|
@deepti-imx @imx-mikhala @sharonsheah just curious about the thinking here with refactoring the AvailabilityService from a class to a factory function? |
Was something I suggested. It feels a lot easier to read than a class - no need for |
deepti-imx
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://immutable.atlassian.net/browse/WT-1781
Things worth calling out
See comments
Before submitting the PR, please consider the following:
feat:,fix:,chore:,docs:, orrefactor:.