New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: ID-1133 Updated Passport sample app to display orders inclusive of fees #999

Merged

haydenfowler merged 2 commits into main from feature/ID-1133-display-fees-correctly

Oct 17, 2023

Contributor

haydenfowler commented Oct 17, 2023

Summary

This PR:

Adds auxiliary fee's to the listOrders calls to ensure that the price displayed is consistent with the transaction confirmation screen
Updates the listOrders call on the Trade screen to be desc (e.g. most recent orders first)
Moves the fee address & percentage to config/index.ts
Renames all values in config/index.ts to be CONSTANT_CASE


          ID-1133 Updated Passport sample app to display orders inclusive of fees

e362148

haydenfowler requested a review from a team as a code owner

October 17, 2023 01:03


          Merge branch 'main' into feature/ID-1133-display-fees-correctly

yundifu approved these changes

View reviewed changes

haydenfowler merged commit 9b21822 into main

6 checks passed

haydenfowler deleted the feature/ID-1133-display-fees-correctly branch

October 17, 2023 03:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment