You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
bc4493a introduces a redundant null check for JDK maps. I found this because Spotbugs complains abound loading a known null value. The generated code looks like the following example:
if (v == null) Objects.requireNonNull(v, "value for key: " + k);
Obviously, it makes no sense to call Objects.requireNonNull() on a value known to be null. The if (v == null) is new since the mentioned commit. I don't think this should be there. Without it the code looks fine to me.
The text was updated successfully, but these errors were encountered:
bc4493a introduces a redundant null check for JDK maps. I found this because Spotbugs complains abound loading a known null value. The generated code looks like the following example:
Obviously, it makes no sense to call
Objects.requireNonNull()
on a value known to be null. Theif (v == null)
is new since the mentioned commit. I don't think this should be there. Without it the code looks fine to me.The text was updated successfully, but these errors were encountered: