Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support @Value.Default on Java 8 default methods #61

Closed
cjkent opened this issue Dec 5, 2014 · 2 comments
Closed

Support @Value.Default on Java 8 default methods #61

cjkent opened this issue Dec 5, 2014 · 2 comments
Labels
enhancement
Milestone
1.1

Comments

@cjkent
Copy link

cjkent commented Dec 5, 2014

If a default interface method is annotated with @Value.Default the generated class contains a call to super.foo() which is invalid when calling a default method. The correct syntax would be Foo.super.foo() where Foo is the interface type.
@elucash
Copy link
Member

elucash commented Dec 5, 2014

I'll try to see if this notation (Foo.super.foo()) will work seamlessly for any abstract value type. If not then we'll have do add some specific check. Thanks!

elucash added a commit that referenced this issue Dec 16, 2014
@elucash
Support @Value.Default on Java 8 default methods. #61
ddcad26
@elucash elucash added this to the 1.1 milestone Dec 17, 2014
elucash added a commit that referenced this issue Dec 19, 2014
@elucash
refined support for java 8 default methods. #61
c80dba0
@elucash
Copy link
Member

elucash commented Dec 23, 2014

Verified fix with 1.1.0-rc1.
Thanks for reporting this omission!

@elucash elucash closed this as completed Dec 23, 2014
@cjkent cjkent mentioned this issue Dec 27, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
2 participants
@cjkent @elucash