Staged and strict builders do not work with deepImmutablesDetection

[Diagoras]

Hey,

Using version 2.6.1, I've noticed that staged builder being set to true seems to break deep immutables detection. Modifying the example from the documentation:

@Value.Immutable
@Value.Style(deepImmutablesDetection = true, stagedBuilder = true)
public interface PointHolder {
  Point point();
}

@Value.Immutable
@Value.Style(allParameters = true)
public interface Point {
  int x();
  int y();
}

ImmutablePointHolder line = ImmutablePointHolder.builder()
  .point(1, 2) // Compile time error, expects Point
  .build();
}

Setting stagedBuilder = false seems to resolve the issue.

[elucash]

Thank you for reporting this! I would say that it just skips (doesn't support) those shortcut initializers that deepImmutableDetection provides. I'll see how hard it would be to support those on stage interfaces: this might be an easy-to-fix, low-hanging fruit. But in general, we can expect staged builders to be more restrictive and having fewer features than regular builders.

[Diagoras]

Yeah, that makes sense. I hope it's workable, but we'll see.

[Diagoras]

@elucash Started looking into this by creating test cases that demonstrate the problem (turns out deepImmutablesDetection isn't working for strictBuilder too). Ran into a weird issue with generating a staged builder on the test class, have you seen anything like this before?