Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required attribute to generated @JsonProperty on a field #924

Open
JaroKuruc opened this issue Mar 18, 2019 · 1 comment
Open

Add required attribute to generated @JsonProperty on a field #924

JaroKuruc opened this issue Mar 18, 2019 · 1 comment

Comments

@JaroKuruc
Copy link

In order to better support JSON schema generation, it would be helpful if generated @JsonProperty on mandatory fields also contained required=true attribute. This would then be inline with the logic in generated builder which is checking that mandatory fields are set.

@elucash
Copy link
Member

elucash commented Mar 19, 2019

thanks for pointing this out! while I'm not aware of much of the functional usage of the JsonProperty.required attribute, but having this attribute set should be good for consistency whether it is functional or just a metadata piece

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants