#1189: criteria-geode backend toLowerCase/toUpperCase add parentheses

[garrettlestingi]

This was a small change so I took a crack at it. Below is the log evidence that toUpperCase and toLowerCase is now working in my example app:

Jun 17, 2020 2:37:58 AM org.immutables.criteria.geode.SyncSelect call
FINE: Querying Geode with oql=[SELECT * FROM /person WHERE name.toLowerCase() = $1]  with 1 variables [$1=garrett]
Jun 17, 2020 2:37:58 AM Main main
INFO: toLowerCase() number of results: 2
Jun 17, 2020 2:37:58 AM org.immutables.criteria.geode.SyncSelect call
FINE: Querying Geode with oql=[SELECT * FROM /person WHERE name.toUpperCase() = $1]  with 1 variables [$1=GARRETT]
Jun 17, 2020 2:37:58 AM Main main
INFO: toUpperCase() number of results: 2
Jun 17, 2020 2:37:58 AM org.immutables.criteria.geode.SyncSelect call
FINE: Querying Geode with oql=[SELECT * FROM /person WHERE name = $1]  with 1 variables [$1=garrett]
Jun 17, 2020 2:37:58 AM Main main
INFO: is number of results: 1

[asereda-gs]

Thanks for contribution!

Does it mean that existing upperLower test is invalid ?

Even their example doesn't use parenthesis (()):

SELECT * FROM /exampleRegion WHERE foo.toLowerCase LIKE '%bar%'

From what I remember it is optional in Geode.

But is is hard to argue if your concrete example doesn't work.

[garrettlestingi]

Thanks for the quick response!

I believe the upperLower test case from the GeodeIntegrationTest is using AutoCreateRegion to create a LOCAL region. Using a LOCAL region returns expected results without the parentheses even in my concrete example:

    // if not, create
    cache.createRegionFactory()
            .setScope(Scope.LOCAL) // otherwise ConcurrentMap API doesn't work for Region
            .setValueConstraint(valueConstraint)
            .create(name);

I was also confused why the only example in their documentation does not use parentheses, but when I test using queries in gfsh similar to their example, these are my results:

gfsh>query --query="select count(*) from /person where name.toLowerCase LIKE '%garrett%'"
Result : true
Rows   : 1

Result
------
0
gfsh>query --query="select count(*) from /person where name.toLowerCase() LIKE '%garrett%'"
Result : true
Rows   : 1

Result
------
2

[asereda-gs]

Thanks for PR!