Support abstract classes declaring static interned instances of their own type #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stephan202
commented
Mar 18, 2021
| @Value.Immutable(intern = true) | ||
| @Value.Style(allParameters = true) | ||
| abstract class InternedClassWithSelfConstant { | ||
| public static final ImmutableInternedClassWithSelfConstant FOO = ImmutableInternedClassWithSelfConstant.of("foo"); |
There was a problem hiding this comment.
This is what the PR is about: the changes make this construction possible.
| public class InternedClassWithSelfConstantTest { | ||
| @Test | ||
| public void testInstantiation() { | ||
| assertSame(ImmutableInternedClassWithSelfConstant.of("foo"), ImmutableInternedClassWithSelfConstant.FOO); |
There was a problem hiding this comment.
Without the fix below this test fails with:
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.017 s <<< FAILURE! - in org.immutables.fixture.InternedClassWithSelfConstantTest
[ERROR] testInstantiation Time elapsed: 0.015 s <<< ERROR!
java.lang.ExceptionInInitializerError
at org.immutables.fixture.InternedClassWithSelfConstantTest.testInstantiation(InternedClassWithSelfConstantTest.java:24)
Caused by: java.lang.NullPointerException
at org.immutables.fixture.InternedClassWithSelfConstantTest.testInstantiation(InternedClassWithSelfConstantTest.java:24)
| @@ -697,21 +697,23 @@ public [type.typeAbstract.relative] [v.names.with]([v.atNullability][v.type] val | |||
| [else if type.useSingletonOnly][-- deliberately left empty --] | |||
| [else if type.useInterned] | |||
|
|
|||
| private static final class InternerHolder { | |||
There was a problem hiding this comment.
We're effectively applying the Initialization-on-demand holder idiom.
Stephan202
force-pushed
the
bugfix/interning-self-constants
branch
from
c347c64
to
9cd6cc7
Compare
elucash
reviewed
Apr 16, 2021
| [else] | ||
| private static final java.util.concurrent.ConcurrentHashMap<InternProxy, [type.typeImmutable.relative]> INTERNER = | ||
| static final java.util.concurrent.ConcurrentHashMap<InternProxy, [type.typeImmutable.relative]> INTERNER = |
There was a problem hiding this comment.
I'm merging this, just in case what removing private does here
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary says it.