Re-try to resolve types in java.lang #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because `java.lang` types get automatically imported, they can be "resolved" without being resolved to the same thing that they are in the source file. This ultimately winds up preventing the generated code from compiling.
|
Thank you for PR! This should be important to fix this. Let me some time to understand the problem, the solution space and the specific fix in this PR. The fix looks good and quite compact, just need to understand how it all works together. |
|
I'll merge it, but after investigation, might change the way it works, currently it's a bit enigmatic to me. Thank you! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
java.langtypes get automatically imported, they can be "resolved" without being resolved to the same thing that they are in the source file. This ultimately winds up preventing the generated code from compiling.I'd love any guidance you're willing to give around this / around testing this out. Thank you!
Closes #1475