Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confused about versioning #24

Closed
acampagna opened this issue Jul 20, 2016 · 3 comments
Closed

Confused about versioning #24

acampagna opened this issue Jul 20, 2016 · 3 comments

Comments

@acampagna
Copy link

The readme files make this a bit confusing because in master it says use 2.x. But then when you goto 2.x it says use master for "2.1.0 and above".

Is master for the latest ES 2.x (2.3.4) release or is it for ES 5.0 (might have been named ES3.0 when you last updated the project)?

@imotov
Copy link
Owner

imotov commented Jul 20, 2016

The master branch of this plugin was tracking the master branch of elasticsearch when it was 3.0 but it is not in active development any more because I am in the process of moving this example into the main elasticsearch project. The PR is in the review process and can be found here - elastic/elasticsearch/pull/19334 When this PR is merged I will probably remove the master branch here and only leave 2.x and 1.x branches for historical reasons.

@acampagna
Copy link
Author

Thank you very much. That makes perfect sense.

@mtraynham
Copy link

@imotov I guess you closed it.

I'm curious, if you were to recreate the lookupIndex function for 5.0, how would you go about it, i.e. how would you pass a NodeClient to the script factory? I'd somewhat like'd to retain this functionality, so if you have any suggestions, that would be awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants