Skip to content

Commit

Permalink
Fix: Bot PRs need approving review before they can be merged
Browse files Browse the repository at this point in the history
I missed this before, but because we have it as a requirement that PRs need an approving review, the bot PRs are still not being auto-merged.

This change should fix that.
  • Loading branch information
alexdewar committed Jun 20, 2024
1 parent cf26c0f commit aa1ebd1
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .github/workflows/auto-merge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ jobs:
if: ${{ github.event.pull_request.user.login == 'dependabot[bot]' || github.event.pull_request.user.login == 'pre-commit-ci[bot]' }}
steps:
- name: Enable auto-merge for Dependabot PRs
run: gh pr merge --auto --merge "$PR_URL"
run: |
gh pr review --approve "$PR_URL"
gh pr merge --auto --merge "$PR_URL"
env:
PR_URL: ${{github.event.pull_request.html_url}}
# GitHub provides this variable in the CI env. You don't
Expand Down

0 comments on commit aa1ebd1

Please sign in to comment.