Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Extension trait for SIOPv2 and OID4VP #60

Merged
merged 18 commits into from
Mar 12, 2024

Conversation

nanderstabel
Copy link
Collaborator

@nanderstabel nanderstabel commented Feb 22, 2024

Description of change

This PR includes several changes:

  • Use of JsonValue instead of serde_json::Value
  • Refactor of AuthorizationRequest (in oid4vc-core/src/authorization_request.rs) which means the previous awkward RequestUrl is deprecated. Possible variations of AuthorizationRequest are now: AuthorizationRequest<ByValue>, AuthorizationRequest<Object>, AuthorizationRequest<Object<SIOPv2>>, and AuthorizationRequest<Object<OID4VP>>.
  • A new Extension trait (defined in oid4vc-core/src/openid4vc_extension.rs), which allows for a clearer distinction between oid4vc-core, siopv2 and oid4vp. The core part of both AuthorizationRequest and AuthorizationResponse or now moved to the oid4vc-core crate.
  • ClientMetadata and Scope are moved to oid4vc-core as well now.
  • Upgraded ed25519_dalek dev-dependency.
  • Temporary removed the outdated iota DID method.

Links to any relevant issues

#42

How the change has been tested

Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@nanderstabel nanderstabel changed the title Feat/extension trait feat: add Extension trait for SIOPv2 and OID4VP Feb 22, 2024
@nanderstabel nanderstabel added the Breaking change A change to the API that requires a major release. label Feb 22, 2024
@nanderstabel nanderstabel self-assigned this Feb 22, 2024
@nanderstabel nanderstabel marked this pull request as ready for review February 22, 2024 21:45
@nanderstabel nanderstabel merged commit d05bd55 into dev Mar 12, 2024
@nanderstabel nanderstabel deleted the feat/extension-trait branch March 12, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change A change to the API that requires a major release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants