Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.2.2 doesn't include project files #135

Closed
jyeros opened this issue Jul 5, 2022 · 8 comments · Fixed by #137 or #139
Closed

3.2.2 doesn't include project files #135

jyeros opened this issue Jul 5, 2022 · 8 comments · Fixed by #137 or #139

Comments

@jyeros
Copy link

jyeros commented Jul 5, 2022

v3.2.2 doesn't include project files
image

These are the only 3 files:
image

@ixuz
Copy link

ixuz commented Jul 5, 2022

Transition from version 3.2.1 to 3.2.2 caused our CI pipeline to fail.
Errors like these appear in the eslint log:

   1:1   error    Resolve error: typescript with invalid interface loaded as resolver  import/namespace
   1:1   error    Resolve error: typescript with invalid interface loaded as resolver  import/no-unresolved
   1:1   error    Resolve error: typescript with invalid interface loaded as resolver  import/default
   1:1   warning  Resolve error: typescript with invalid interface loaded as resolver  import/no-duplicates
   1:1   error    Resolve error: typescript with invalid interface loaded as resolver  import/no-extraneous-dependencies
   1:1   error    Resolve error: typescript with invalid interface loaded as resolver  import/order
   1:1   error    Resolve error: typescript with invalid interface loaded as resolver  import/no-self-import
   1:1   error    Resolve error: typescript with invalid interface loaded as resolver  import/no-cycle
   1:1   error    Resolve error: typescript with invalid interface loaded as resolver  import/no-relative-packages
   1:1   warning  Resolve error: typescript with invalid interface loaded as resolver  import/no-named-as-default
   1:1   warning  Resolve error: typescript with invalid interface loaded as resolver  import/no-named-as-default-member
   1:1   error    Resolve error: typescript with invalid interface loaded as resolver  import/extensions
   1:1   error    Resolve error: typescript with invalid interface loaded as resolver  import/no-useless-path-segments
   1:1   error    Resolve error: typescript with invalid interface loaded as resolver  import/named

@minddust
Copy link

minddust commented Jul 5, 2022

+1

@JounQin
Copy link
Collaborator

JounQin commented Jul 6, 2022

I'm sorry for this accident, I'll check ASAP.

@JounQin
Copy link
Collaborator

JounQin commented Jul 6, 2022

@jyeros @kristinlindquist @hori-ryota @melink14 @cherryblossom000 @minddust @meriouma @alecthw

eslint-import-resolver-typescript@3.2.4 has been released with correct contents.


If you found my projects useful, please consider donating such as a cup of coffee, thanks.

amikheychik added a commit to perfective/eslint-config that referenced this issue Jul 6, 2022
@Lonli-Lokli
Copy link

I am not sure yet what is the reason, but my import/order stopped working when I switched to Yarn PnP - it does not treat projects starting with @cv as internal, with this configuration

"import/order": [
          "error",
          {
            "groups": [["builtin", "external"], "internal", ["parent", "sibling", "index"]],
            "pathGroups": [
              {
                "pattern": "@cv/**",
                "group": "internal"
              }
            ],
            "pathGroupsExcludedImportTypes": ["builtin"],
            "newlines-between": "always",
            "warnOnUnassignedImports": true,
            "alphabetize": {
              "order": "asc",
              "caseInsensitive": true
            }
          }
        ],

@JounQin
Copy link
Collaborator

JounQin commented Aug 5, 2022

@Lonli-Lokli https://antfu.me/posts/why-reproductions-are-required

yarn PnP's resolved path is much different.

@Lonli-Lokli
Copy link

@JounQin how small should be reproduction? Because now I already have my project with that, and Yarn PnP was not a small task

@JounQin
Copy link
Collaborator

JounQin commented Aug 5, 2022

@JounQin how small should be reproduction? Because now I already have my project with that, and Yarn PnP was not a small task

Your issue seems not related to project size, so just a reproduction is needed, no matter its size.

And also, please raise a new issue with the reproduction, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants