feat!: use enhanced-resolve instead #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ijjk
added a commit
to vercel/next.js
that referenced
this pull request
Nov 16, 2022
…3010) <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change that you're making: --> ## Bug Bumps `eslint-import-resolver-typescript` in `eslint-config-next` to the latest version to pick up a fix from `3.1.0`. As mentioned here, import-js/eslint-import-resolver-typescript#107, the typescript parser is unable to resolve the `typesVersions ` field in their `package.json`. An example repo using this is [`@vercel/examples-ui`](https://github.com/vercel/examples/blob/385a2e968619f9e50f488e2857e021841ae61030/packages/ui/package.json#L14-L22) which will report an eslint `import/no-unresolved` error when using the previous version of `eslint-import-resolver-typescript` (see import-js/eslint-import-resolver-typescript#107). This was fixed in import-js/eslint-import-resolver-typescript#110 This can be locally fixed by bumping `>=eslint-import-resolver-typescript@3.1.0` but decided it should be resolved here too. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [x] Errors have a helpful link attached, see `contributing.md` Closes: #41786 Co-authored-by: JJ Kasper <jj@jjsweb.site>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #85, close #107