Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import from CJS lib #241

Merged
merged 3 commits into from Sep 22, 2023
Merged

Fix import from CJS lib #241

merged 3 commits into from Sep 22, 2023

Conversation

klippx
Copy link
Contributor

@klippx klippx commented Sep 21, 2023

Fixes #238

@changeset-bot
Copy link

changeset-bot bot commented Sep 21, 2023

🦋 Changeset detected

Latest commit: 40eef1a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-import-resolver-typescript Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@klippx klippx force-pushed the fix-cjs-import branch 2 times, most recently from 7b95abb to 6b6b154 Compare September 21, 2023 13:23
@klippx
Copy link
Contributor Author

klippx commented Sep 21, 2023

Only problem is CI is broken... Package.json says

"packageManager": "pnpm@8.0.0",

And I am running on latest:

> eslint-import-resolver-typescript % pnpm -v
8.6.1

And it works:

eslint-import-resolver-typescript % pnpm i --frozen-lockfile
Lockfile is up to date, resolution step is skipped
Already up to date

> eslint-import-resolver-typescript@3.6.0 prepare /Users/MKLIPPIN/repos/eslint-import-resolver-typescript
> simple-git-hooks

[INFO] Successfully set the pre-commit with command: pnpm lint-staged
[INFO] Successfully set the commit-msg with command: pnpm commitlint -e
[INFO] Successfully set all git hooks
Done in 917ms

I have also tried installing EXACTLY 8.0.0 (which is a huge hassle) but it was the same, CI is broken.

I beieve your CI is running on some older version of pnpm (7?) and they need to be updated

@JounQin
Copy link
Collaborator

JounQin commented Sep 21, 2023

@klippx Can you help to update pnpm in package.json to 8.7.6?

image

I'm using gitpod currently.

src/index.ts Outdated Show resolved Hide resolved
@JounQin JounQin merged commit cf5d67f into import-js:master Sep 22, 2023
4 of 6 checks passed
@JounQin JounQin deleted the fix-cjs-import branch September 22, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

ERROR import {sync as globSync} from 'fast-glob';
2 participants