New: no-unused-modules rule - added more tests

Signed-off-by: René Fermann <rene.fermann@gmx.de>
import-js · Jul 31, 2018 · 230122b · 230122b
1 parent a402023
commit 230122b
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 2 deletions.
diff --git a/tests/files/no-unused-modules/empty_file.js b/tests/files/no-unused-modules/empty_file.js
diff --git a/tests/files/no-unused-modules/node_modules.js b/tests/files/no-unused-modules/node_modules.js
diff --git a/tests/src/rules/no-unused-modules.js b/tests/src/rules/no-unused-modules.js
@@ -1,6 +1,9 @@
 import { test, testFilePath } from '../utils'
 
 import { RuleTester } from 'eslint'
+import { expect } from 'chai';
+
+const doPreparation = require( '../../../src/rules/no-unused-modules').doPreparation
 
 const ruleTester = new RuleTester()
     , rule = require('rules/no-unused-modules')
@@ -17,6 +20,26 @@ const unusedExportsOptions = [{
   ignore: [testFilePath('./no-unused-modules/*ignored*.js')],
 }]
 
+describe('doPreparation throws correct errors', () => {
+  // const fn = doPreparation()
+  const context = {id: 'no-unused-modules' }
+  it('should throw an error, if src is not an array', () => {
+    expect(doPreparation.bind(doPreparation, null,  null, context)).to.throw(`Rule ${context.id}: src option must be an array`)
+  })
+  it('should throw an error, if ignore is not an array', () => {
+    expect(doPreparation.bind(doPreparation, [], null, context)).to.throw(`Rule ${context.id}: ignore option must be an array`)
+  })
+  it('should throw an error, if src is empty', () => {
+    expect(doPreparation.bind(doPreparation, [],  [], context)).to.throw(`Rule ${context.id}: src option must be defined`)
+  })
+  it('should throw an error, if src is empty', () => {
+    expect(doPreparation.bind(doPreparation, [""],  [], context)).to.throw(`Rule ${context.id}: src option must not contain empty strings`)
+  })
+  it('should throw an error, if src is empty', () => {
+    expect(doPreparation.bind(doPreparation, ["src"],  [""], context)).to.throw(`Rule ${context.id}: ignore option must not contain empty strings`)
+  })
+})
+
 // tests for missing exports
 ruleTester.run('no-unused-modules', rule, {
   valid: [
@@ -39,6 +62,11 @@ ruleTester.run('no-unused-modules', rule, {
       code: 'const a = 1',
       errors: [error(`No exports found`)],
     }),
+    test({
+      options: missingExportsOptions,
+      code: '/* const a = 1 */',
+      errors: [error(`No exports found`)],
+    }),
   ],
 })
 
@@ -152,7 +180,7 @@ ruleTester.run('no-unused-modules', rule, {
 ruleTester.run('no-unused-modules', rule, {
   valid: [
     test({ options: unusedExportsOptions,
-           code: `import g from '${testFilePath('./no-unused-modules/file-g.js')}'`,
+           code: `import g from '${testFilePath('./no-unused-modules/file-g.js')}';import {h} from '${testFilePath('./no-unused-modules/file-gg.js')}'`,
            filename: testFilePath('./no-unused-modules/file-0.js')}),
     ],
   invalid: [
@@ -166,7 +194,7 @@ ruleTester.run('no-unused-modules', rule, {
 ruleTester.run('no-unused-modules', rule, {
   valid: [
     test({ options: unusedExportsOptions,
-           code: `import { g } from '${testFilePath('./no-unused-modules/file-g.js')}'`,
+           code: `import { g } from '${testFilePath('./no-unused-modules/file-g.js')}'; import eslint from 'eslint'`,
            filename: testFilePath('./no-unused-modules/file-0.js')}),
     test({ options: unusedExportsOptions,
             code: 'export const g = 2',