Skip to content

Commit

Permalink
added tests to support new settings['import/paths'] logic for no-extr…
Browse files Browse the repository at this point in the history
…aneous-dependencies rule
  • Loading branch information
Steven Hargrove committed Feb 7, 2018
1 parent 112dd05 commit 4ce8d72
Show file tree
Hide file tree
Showing 3 changed files with 48 additions and 0 deletions.
6 changes: 6 additions & 0 deletions tests/files/monorepo/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"private": true,
"devDependencies": {
"left-pad": "^1.2.0"
}
}
6 changes: 6 additions & 0 deletions tests/files/monorepo/packages/nested-package/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"name": "nested-monorepo-pkg",
"dependencies": {
"react": "^16.0.0"
}
}
36 changes: 36 additions & 0 deletions tests/src/rules/no-extraneous-dependencies.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ const packageFileWithSyntaxErrorMessage = (() => {
}
})()
const packageDirWithFlowTyped = path.join(__dirname, '../../files/with-flow-typed')
const packageDirMonoRepoRoot = path.join(__dirname, '../../files/monorepo')
const packageDirMonoRepoWithNested = path.join(__dirname, '../../files/monorepo/packages/nested-package')

ruleTester.run('no-extraneous-dependencies', rule, {
valid: [
Expand Down Expand Up @@ -75,8 +77,42 @@ ruleTester.run('no-extraneous-dependencies', rule, {
options: [{packageDir: packageDirWithFlowTyped}],
parser: 'babel-eslint',
}),
test({
code: 'import react from "react";',
options: [{packageDir: packageDirMonoRepoWithNested}],
// filename: path.join(process.cwd(), 'foo.spec.js'),
}),
test({
code: 'import leftpad from "left-pad";',
options: [{packageDir: packageDirMonoRepoWithNested}],
settings: { 'import/paths': [packageDirMonoRepoRoot] },
// filename: path.join(process.cwd(), 'foo.spec.js'),
}),
test({
code: 'import leftpad from "left-pad";',
options: [{packageDir: packageDirMonoRepoRoot}],
settings: { 'import/paths': [packageDirMonoRepoRoot] },
}),
],
invalid: [
test({
code: 'import "not-a-dependency"',
options: [{packageDir: packageDirMonoRepoWithNested}],
settings: { 'import/paths': [packageDirMonoRepoRoot] },
errors: [{
ruleId: 'no-extraneous-dependencies',
message: '\'not-a-dependency\' should be listed in the project\'s dependencies. Run \'npm i -S not-a-dependency\' to add it',
}],
}),
test({
code: 'import "not-a-dependency"',
options: [{packageDir: packageDirMonoRepoRoot}],
settings: { 'import/paths': [packageDirMonoRepoRoot] },
errors: [{
ruleId: 'no-extraneous-dependencies',
message: '\'not-a-dependency\' should be listed in the project\'s dependencies. Run \'npm i -S not-a-dependency\' to add it',
}],
}),
test({
code: 'import "not-a-dependency"',
errors: [{
Expand Down

0 comments on commit 4ce8d72

Please sign in to comment.